refactor: extract all inline CSS/JS from PHP files into separate asset files #88

agent · 2026-06-14T08:04:11-04:00

agent commented

2026-06-14 08:04:11 -04:00

Phase A — HTML removido de archivos PHP (3 archivos)

RateLimitMiddleware.php: heredoc HTML movido a views/errors/429.php (usando renderView)
public/index.php: inline HTML de error reemplazado por View::error(500)
AuthMiddleware.php: <script>window.location reemplazado por <meta http-equiv=refresh>

Phase B — CSS/JS inline extraído de vistas (~20 archivos)

CSS: landing.css (459 líneas), legal.css (compartido terms+privacy)
JS: 17 nuevos archivos en public/assets/js/

Detalle de archivos JS creados:

Archivo	Origen	Líneas
`main.js`	`views/layouts/main.php`	202
`server-show.js`	`views/servers/show.php`	323
`dashboard-chart.js`	`views/dashboard/index.php`	136
`nginx-manager.js`	`views/servers/nginx.php`	315
`database-manager.js`	`views/database/index.php`	300
`terminal.js`	`views/terminal/index.php`	110
`team-show.js`	`views/teams/show.php`	187
`team-index.js`	`views/teams/index.php`	60
`server-services.js`	`views/servers/services.php`	88
`server-ssl.js`	`views/servers/ssl.php`	70
`server-processes.js`	`views/servers/processes.php`	60
`system-users.js`	`views/servers/system_users.php`	40
`server-permissions.js`	`edit.php`+`create.php` (compartido)	80
`server-list.js`	`views/servers/index.php`	30
`admin-users.js`	`views/admin/users.php`	78
`audit-log.js`	`views/admin/audit.php`	42
`admin-notifications.js`	`views/admin/notifications.php`	42
`admin-security.js`	`views/admin/security.php`	19
`notifications.js`	`views/notifications/index.php`	22

Resumen: -3264 líneas de CSS/JS inline, +288 líneas en assets separados. 51 archivos modificados.

## Phase A — HTML removido de archivos PHP (3 archivos) - `RateLimitMiddleware.php`: heredoc HTML movido a `views/errors/429.php` (usando renderView) - `public/index.php`: inline HTML de error reemplazado por `View::error(500)` - `AuthMiddleware.php`: `<script>window.location` reemplazado por `<meta http-equiv=refresh>` ## Phase B — CSS/JS inline extraído de vistas (~20 archivos) - **CSS**: `landing.css` (459 líneas), `legal.css` (compartido terms+privacy) - **JS**: 17 nuevos archivos en `public/assets/js/` ### Detalle de archivos JS creados: | Archivo | Origen | Líneas | |---------|--------|-------| | `main.js` | `views/layouts/main.php` | 202 | | `server-show.js` | `views/servers/show.php` | 323 | | `dashboard-chart.js` | `views/dashboard/index.php` | 136 | | `nginx-manager.js` | `views/servers/nginx.php` | 315 | | `database-manager.js` | `views/database/index.php` | 300 | | `terminal.js` | `views/terminal/index.php` | 110 | | `team-show.js` | `views/teams/show.php` | 187 | | `team-index.js` | `views/teams/index.php` | 60 | | `server-services.js` | `views/servers/services.php` | 88 | | `server-ssl.js` | `views/servers/ssl.php` | 70 | | `server-processes.js` | `views/servers/processes.php` | 60 | | `system-users.js` | `views/servers/system_users.php` | 40 | | `server-permissions.js` | `edit.php`+`create.php` (compartido) | 80 | | `server-list.js` | `views/servers/index.php` | 30 | | `admin-users.js` | `views/admin/users.php` | 78 | | `audit-log.js` | `views/admin/audit.php` | 42 | | `admin-notifications.js` | `views/admin/notifications.php` | 42 | | `admin-security.js` | `views/admin/security.php` | 19 | | `notifications.js` | `views/notifications/index.php` | 22 | **Resumen**: -3264 líneas de CSS/JS inline, +288 líneas en assets separados. 51 archivos modificados.

agent added 1 commit 2026-06-14 08:04:12 -04:00

refactor: extract inline CSS/JS from views into separate asset files (20+ files) 88f3c1f964

Phase A — HTML removed from PHP files:
- RateLimitMiddleware.php: heredoc moved to views/errors/429.php
- public/index.php: inline HTML replaced with View::error()
- AuthMiddleware.php: <script> redirect replaced with <meta refresh>

Phase B — Inline CSS/JS extracted from views:
- CSS: landing.css (459 lines), legal.css (shared by terms+privacy)
- JS: 17 new files extracted from ~20 view files
  - main.js (layout sidebar + notifications)
  - dashboard-chart.js, server-show.js, server-services.js
  - nginx-manager.js, database-manager.js
  - terminal.js, team-show.js, team-index.js
  - server-list.js, server-permissions.js (shared by edit+create)
  - server-ssl.js, server-processes.js, system-users.js
  - admin-users.js, audit-log.js, admin-notifications.js, admin-security.js
  - notifications.js

Total: -3264 lines from views, +288 lines in new assets

rafaga21 approved these changes 2026-06-14 08:05:46 -04:00

rafaga21 merged commit 216a38bc71 into master

2026-06-14 08:05:52 -04:00

rafaga21 referenced this issue from a commit

2026-06-14 08:05:53 -04:00

Merge pull request 'refactor: extract all inline CSS/JS from PHP files into separate asset files' (#88) from fix/policy-container-width into master

rafaga21 deleted branch fix/policy-container-width

2026-06-14 08:05:54 -04:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: devlab/server-manager#88